hubcio commented on code in PR #2958:
URL: https://github.com/apache/iggy/pull/2958#discussion_r2974165496
##########
core/server/src/streaming/partitions/journal.rs:
##########
@@ -19,30 +19,43 @@ use crate::streaming::segments::{IggyMessagesBatchMut,
IggyMessagesBatchSet};
use iggy_common::{IggyByteSize, IggyError};
use std::fmt::Debug;
-// TODO: Will have to revisit this Journal abstraction....
-// I don't like that it has to leak impl detail via the `Inner` struct in
order to be functional.
-
#[derive(Default, Debug)]
pub struct Inner {
- pub base_offset: u64,
+ /// Offset where the next append will land. After commit(), set to
+ /// current_offset + 1. Used in `append()`: `current_offset = next_offset +
+ /// messages_count - 1`.
+ pub next_offset: u64,
Review Comment:
i reverted back to the original name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
