avirajkhare00 commented on issue #2927:
URL: https://github.com/apache/iggy/issues/2927#issuecomment-4064467774

   I can take a first pass on this.
   
   I checked the sink runtime path first. In 
`core/connectors/runtime/src/sink.rs`, `process_messages` serializes the batch 
and invokes the sink consume callback, but the runtime currently does not 
appear to use a return value from that callback before counting the batch as 
processed. That suggests the issue is in the runtime or plugin contract, not 
only in per-sink logic.
   
   My plan is:
   1. Trace the sink callback ABI and confirm what success or failure signal 
the runtime is supposed to receive from plugins.
   2. Update the runtime so failed consume calls are not treated as 
successfully processed.
   3. Add or extend an integration test around the connectors runtime path so 
the regression is covered.
   
   This one looks a bit more invasive than the script or chart issues, but I am 
happy to dig into it if maintainers are okay with that direction.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to