manojpec commented on a change in pull request #4352: URL: https://github.com/apache/hudi/pull/4352#discussion_r781020342
########## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieKeyMetaIndexBatchLookupHandle.java ########## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.io; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.Path; +import org.apache.hudi.common.bloom.BloomFilter; +import org.apache.hudi.common.bloom.BloomFilterTypeCode; +import org.apache.hudi.common.bloom.HoodieDynamicBoundedBloomFilter; +import org.apache.hudi.common.model.HoodieBaseFile; +import org.apache.hudi.common.model.HoodieRecordPayload; +import org.apache.hudi.common.model.HoodieTableType; +import org.apache.hudi.common.util.HoodieTimer; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.collection.Pair; +import org.apache.hudi.common.util.hash.FileIndexID; +import org.apache.hudi.common.util.hash.PartitionIndexID; +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.exception.HoodieIndexException; +import org.apache.hudi.table.HoodieTable; +import org.apache.log4j.LogManager; +import org.apache.log4j.Logger; + +import java.nio.ByteBuffer; +import java.nio.charset.StandardCharsets; +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Set; + +/** + * Takes a bunch of keys and returns ones that are present in the file group. + */ +public class HoodieKeyMetaIndexBatchLookupHandle<T extends HoodieRecordPayload, I, K, O> extends HoodieReadHandle<T, + I, K, O> { + + private static final Logger LOG = LogManager.getLogger(HoodieKeyMetaIndexBatchLookupHandle.class); + + private final HoodieTableType tableType; + + private final BloomFilter bloomFilter; + + private final List<String> candidateRecordKeys; + + private long totalKeysChecked; + + public HoodieKeyMetaIndexBatchLookupHandle(HoodieWriteConfig config, HoodieTable<T, I, K, O> hoodieTable, + Pair<String, String> partitionPathFileIdPair, String fileName) { + super(config, null, hoodieTable, partitionPathFileIdPair); + this.tableType = hoodieTable.getMetaClient().getTableType(); + + this.candidateRecordKeys = new ArrayList<>(); + this.totalKeysChecked = 0; + HoodieTimer timer = new HoodieTimer().startTimer(); + + Option<ByteBuffer> bloomFilterByteBuffer = + hoodieTable.getMetadataTable().getBloomFilter(new PartitionIndexID(partitionPathFileIdPair.getLeft()), + new FileIndexID(fileName)); + if (!bloomFilterByteBuffer.isPresent()) { + throw new HoodieIndexException("BloomFilter missing for " + fileName); + } + + // TODO: Go via the factory and the filter type + this.bloomFilter = + new HoodieDynamicBoundedBloomFilter(StandardCharsets.UTF_8.decode(bloomFilterByteBuffer.get()).toString(), + BloomFilterTypeCode.DYNAMIC_V0); + + LOG.debug(String.format("Read bloom filter from %s,%s, size: %s in %d ms", partitionPathFileIdPair, fileName, + bloomFilterByteBuffer.get().array().length, timer.endTimer())); + } + + /** + * Given a list of row keys and one file, return only row keys existing in that file. + */ + public List<String> checkCandidatesAgainstFile(Configuration configuration, List<String> candidateRecordKeys, + Path filePath) throws HoodieIndexException { + List<String> foundRecordKeys = new ArrayList<>(); + try { + // Load all rowKeys from the file, to double-confirm + if (!candidateRecordKeys.isEmpty()) { + HoodieTimer timer = new HoodieTimer().startTimer(); + Set<String> fileRowKeys = createNewFileReader().filterRowKeys(new HashSet<>(candidateRecordKeys)); + foundRecordKeys.addAll(fileRowKeys); + LOG.debug(String.format("Checked keys against file %s, in %d ms. #candidates (%d) #found (%d)", filePath, + timer.endTimer(), candidateRecordKeys.size(), foundRecordKeys.size())); + LOG.debug("Keys matching for file " + filePath + " => " + foundRecordKeys); + } + } catch (Exception e) { + throw new HoodieIndexException("Error checking candidate keys against file.", e); + } + return foundRecordKeys; + } + + /** + * Adds the key for look up. + */ + public void addKey(String recordKey) { + // check record key against bloom filter of current file & add to possible keys if needed + if (bloomFilter.mightContain(recordKey)) { + if (LOG.isDebugEnabled()) { + LOG.debug("Record key " + recordKey + " matches bloom filter in " + partitionPathFilePair); + } + candidateRecordKeys.add(recordKey); + } + totalKeysChecked++; + } + + /** + * Of all the keys, that were added, return a list of keys that were actually found in the file group. + */ + public MetaBloomIndexGroupedKeyLookupResult getLookupResult() { + if (LOG.isDebugEnabled()) { + LOG.debug("#The candidate row keys for " + partitionPathFilePair + " => " + candidateRecordKeys); + } + + HoodieBaseFile dataFile = getLatestDataFile(); + List<String> matchingKeys = + checkCandidatesAgainstFile(hoodieTable.getHadoopConf(), candidateRecordKeys, new Path(dataFile.getPath())); + LOG.debug( + String.format("Total records (%d), bloom filter candidates (%d)/fp(%d), actual matches (%d)", totalKeysChecked, + candidateRecordKeys.size(), candidateRecordKeys.size() - matchingKeys.size(), matchingKeys.size())); + return new MetaBloomIndexGroupedKeyLookupResult(partitionPathFilePair.getRight(), partitionPathFilePair.getLeft(), + dataFile.getCommitTime(), matchingKeys); + } + + /** + * Encapsulates the result from a key lookup. + */ + public static class MetaBloomIndexGroupedKeyLookupResult { Review comment: This is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
