cdmikechen commented on a change in pull request #4451:
URL: https://github.com/apache/hudi/pull/4451#discussion_r780322456
##########
File path:
hudi-kafka-connect/src/main/java/org/apache/hudi/connect/writers/KafkaConnectConfigs.java
##########
@@ -93,6 +93,17 @@
.defaultValue(true)
.withDocumentation("Commit even when some records failed to be written");
+ // Reference
https://docs.confluent.io/kafka-connect-hdfs/current/configuration_options.html#hdfs
+ public static final ConfigProperty<String> HADOOP_CONF_DIR = ConfigProperty
+ .key("hadoop.conf.dir")
+ .defaultValue("")
Review comment:
@yihua
Have replace this~
##########
File path: hudi-kafka-connect/pom.xml
##########
@@ -271,5 +271,12 @@
<artifactId>junit-platform-commons</artifactId>
<scope>test</scope>
</dependency>
+
+ <dependency>
Review comment:
@codope @yihua
I reconsidered and modified the codes. Use `System.env` to get environment
variables should not be necessary in these test cases, so I deleted
dependencies and related codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
