nsivabalan commented on pull request #4428: URL: https://github.com/apache/hudi/pull/4428#issuecomment-1006642838
Probably we can skip adding it to plan. here is the use-case. lets say a compaction was triggered w/ preserve commit metadata enabled and mid way users thinks that he does not want preserve commit metadata to be enabled. and so cancels on-going compaction. changes write config to disable preserve commit metadata and restarts. but since we serialized the value to the plan, we will re-execute it from scratch but with preserve commit metadata enabled right ? guess we can't do much. so, better not to serialize the value to the plan. and always honor current write configs. Let me know what do you think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
