manojpec commented on a change in pull request #4243:
URL: https://github.com/apache/hudi/pull/4243#discussion_r766156617
##########
File path:
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java
##########
@@ -133,7 +133,8 @@ public static void deleteMetadataTable(String basePath,
HoodieEngineContext cont
public static List<HoodieRecord>
convertMetadataToRecords(HoodieCleanMetadata cleanMetadata, String instantTime)
{
List<HoodieRecord> records = new LinkedList<>();
int[] fileDeleteCount = {0};
- cleanMetadata.getPartitionMetadata().forEach((partition,
partitionMetadata) -> {
+ cleanMetadata.getPartitionMetadata().forEach((partitionName,
partitionMetadata) -> {
+ final String partition = partitionName.equals("") ? NON_PARTITIONED_NAME
: partitionName;
Review comment:
isn't update() method a right place for this? That is the origin for all
convert metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
