zhangyue19921010 commented on a change in pull request #4172:
URL: https://github.com/apache/hudi/pull/4172#discussion_r765637844
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTimelineArchiveLog.java
##########
@@ -158,8 +158,8 @@ public boolean archiveIfRequired(HoodieEngineContext
context) throws IOException
// TODO (na) : Add a way to return actions associated with a timeline and
then merge/unify
// with logic above to avoid Stream.concats
HoodieTimeline commitTimeline = table.getCompletedCommitsTimeline();
- Option<HoodieInstant> oldestPendingCompactionInstant =
-
table.getActiveTimeline().filterPendingCompactionTimeline().firstInstant();
+ Option<HoodieInstant> oldestPendingCompactionAndReplaceInstant =
+
table.getActiveTimeline().filterPendingCompactionAndReplaceTimeline().firstInstant();
Review comment:
Sure thing, changed. Maybe use `!s.isComplete` same as before is more
accurate than `filterInflightsAndRequested()` :>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
