xushiyan commented on a change in pull request #4172:
URL: https://github.com/apache/hudi/pull/4172#discussion_r762617715
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiveLog.java
##########
@@ -243,6 +243,36 @@ public void testArchiveCommitSavepointNoHole() throws
Exception {
"Archived commits should always be safe");
}
+ @Test
+ public void testPendingClusteringWillBlockArchival() throws Exception {
+ init();
+ HoodieWriteConfig cfg = HoodieWriteConfig.newBuilder().withPath(basePath)
+
.withSchema(HoodieTestDataGenerator.TRIP_EXAMPLE_SCHEMA).withParallelism(2,
2).forTable("test-trip-table")
+
.withCompactionConfig(HoodieCompactionConfig.newBuilder().retainCommits(1).archiveCommitsWith(2,
5).build())
+ .withFileSystemViewConfig(FileSystemViewStorageConfig.newBuilder()
+ .withRemoteServerPort(timelineServicePort).build())
+
.withMetadataConfig(HoodieMetadataConfig.newBuilder().enable(false).build())
Review comment:
can you do `@ParameterizedTest` of true/false for metadata table
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java
##########
@@ -136,6 +136,14 @@ public HoodieTimeline filterPendingCompactionTimeline() {
instants.stream().filter(s ->
s.getAction().equals(HoodieTimeline.COMPACTION_ACTION) && !s.isCompleted()),
details);
}
+ @Override
+ public HoodieTimeline filterPendingCompactionAndClusteringTimeline() {
Review comment:
```suggestion
public HoodieTimeline filterPendingCompactionAndReplaceTimeline() {
```
insert overwrite, partition delete or clustering all result in replace commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
