minihippo commented on a change in pull request #4152:
URL: https://github.com/apache/hudi/pull/4152#discussion_r760272304



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/strategy/LogFileSizeBasedCompactionStrategy.java
##########
@@ -39,8 +40,12 @@
   @Override
   public List<HoodieCompactionOperation> orderAndFilter(HoodieWriteConfig 
writeConfig,
       List<HoodieCompactionOperation> operations, List<HoodieCompactionPlan> 
pendingCompactionPlans) {
+    // Filter the file group which log files size is greater than the 
threshold in bytes.
     // Order the operations based on the reverse size of the logs and limit 
them by the IO
-    return super.orderAndFilter(writeConfig, 
operations.stream().sorted(this).collect(Collectors.toList()),
+    long threshold = writeConfig.getCompactionLogFileSizeThreshold();

Review comment:
       already fix




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to