boneanxs commented on a change in pull request #4014: URL: https://github.com/apache/hudi/pull/4014#discussion_r760151618
########## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieROTablePathFilter.java ########## @@ -231,6 +240,12 @@ public boolean accept(Path path) { } } + @VisibleForTesting Review comment: As CheckStyle doesn't encourage to import `com.google.common.annotations.VisibleForTesting` annotation. I simply follow `metaClientCache` to make `nonHoodiePathCache` access specifier is `friendly` for test purpose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org