This is an automated email from the ASF dual-hosted git repository.

yihua pushed a commit to branch revert-4116-BitCaskDiskMap_delete_modified
in repository https://gitbox.apache.org/repos/asf/hudi.git

commit 7c8ddb42aa8e8ae597c00635c415368860604ead
Author: Y Ethan Guo <ethan.guoyi...@gmail.com>
AuthorDate: Tue Nov 30 17:43:12 2021 -0800

    Revert "[HUDI-2856] Bit cask disk map delete modified (#4116)"
    
    This reverts commit 257a6a74569cdb500b06c53b92d05f6f5833aa31.
---
 .../java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
 
b/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
index 7644afa..289901d 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
@@ -281,12 +281,12 @@ public final class BitCaskDiskMap<T extends Serializable, 
R extends Serializable
           }
         }
       }
+      writeOnlyFile.delete();
+      this.iterators.forEach(ClosableIterator::close);
     } catch (Exception e) {
       // delete the file for any sort of exception
-      LOG.error("BitCaskDisMap close error ", e);
-    } finally {
-      this.iterators.forEach(ClosableIterator::close);
       writeOnlyFile.delete();
+    } finally {
       super.close();
     }
   }

Reply via email to