yihua commented on a change in pull request #3952:
URL: https://github.com/apache/hudi/pull/3952#discussion_r757696289
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/spark/SpaceCurveOptimizeHelper.java
##########
@@ -67,40 +69,62 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
+import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
-public class ZCurveOptimizeHelper {
+public class SpaceCurveOptimizeHelper {
private static final String SPARK_JOB_DESCRIPTION = "spark.job.description";
/**
- * Create z-order DataFrame directly
- * first, map all base type data to byte[8], then create z-order DataFrame
+ * Create optimized DataFrame directly
* only support base type data.
long,int,short,double,float,string,timestamp,decimal,date,byte
- * this method is more effective than createZIndexDataFrameBySample
+ * this method is more effective than createOptimizeDataFrameBySample
*
* @param df a spark DataFrame holds parquet files to be read.
- * @param zCols z-sort cols
+ * @param sortCols z-sort/hilbert-sort cols
Review comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]