[GitHub] [hudi] manojpec commented on a change in pull request #4101: [HUDI-2850] Clustering CLI - schedule and run command fixes to avoid NumberFormatException

[GitBox]

manojpec commented on a change in pull request #4101:
URL: https://github.com/apache/hudi/pull/4101#discussion_r757362263



##########
File path: 
hudi-cli/src/main/java/org/apache/hudi/cli/commands/ClusteringCommand.java
##########
@@ -42,12 +42,12 @@
 
   @CliCommand(value = "clustering schedule", help = "Schedule Clustering")
   public String scheduleClustering(

Review comment:
       Added the java doc.

##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/SparkMain.java
##########
@@ -79,12 +80,14 @@
   }
 
   public static void main(String[] args) throws Exception {
-    String command = args[0];
-    LOG.info("Invoking SparkMain:" + command);
+    final String commandString = args[0];
+    LOG.info("Invoking SparkMain: " + commandString);
+    final SparkCommand cmd = SparkCommand.valueOf(commandString);
 
-    SparkCommand cmd = SparkCommand.valueOf(command);
+    ValidationUtils.checkArgument(args.length >= 4);

Review comment:
       fixed. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org