xushiyan commented on issue #4103: URL: https://github.com/apache/hudi/issues/4103#issuecomment-978757207
@0x574C seems like so. Would you like to add more UT cases in `org.apache.hudi.utils.TestStreamerUtil` that verifies this? @danny0405 could you confirm this? On another matter: while checking the code, i saw these 2 lines in `org.apache.hudi.util.StreamerUtil#flinkConf2TypedProperties` can be removed now due to #4077 ``` // ugly: table keygen clazz, needed by TwoToThreeUpgradeHandler properties.put(HoodieTableConfig.KEY_GENERATOR_CLASS_NAME.key(), conf.getString(FlinkOptions.KEYGEN_CLASS_NAME)); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org