xushiyan commented on a change in pull request #4113:
URL: https://github.com/apache/hudi/pull/4113#discussion_r756511879
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTimelineArchiveLog.java
##########
@@ -140,20 +140,6 @@ public boolean archiveIfRequired(HoodieEngineContext
context) throws IOException
}
}
- private Stream<HoodieInstant> getCleanInstantsToArchive() {
- HoodieTimeline cleanAndRollbackTimeline = table.getActiveTimeline()
-
.getTimelineOfActions(CollectionUtils.createSet(HoodieTimeline.CLEAN_ACTION,
HoodieTimeline.ROLLBACK_ACTION)).filterCompletedInstants();
- return cleanAndRollbackTimeline.getInstants()
-
.collect(Collectors.groupingBy(HoodieInstant::getAction)).values().stream()
- .map(hoodieInstants -> {
- if (hoodieInstants.size() > this.maxInstantsToKeep) {
- return hoodieInstants.subList(0, hoodieInstants.size() -
this.minInstantsToKeep);
- } else {
- return new ArrayList<HoodieInstant>();
- }
- }).flatMap(Collection::stream);
Review comment:
@nsivabalan @vinothchandar this checks clean and rollback instants
separately against min max thresholds. Is the expected logic to check sum of
them?
##########
File path:
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiveLog.java
##########
@@ -356,13 +356,6 @@ public void testArchiveCommitTimeline() throws Exception {
assertFalse(wrapperFs.exists(markerPath));
}
- private void verifyInflightInstants(HoodieTableMetaClient metaClient, int
expectedTotalInstants) {
Review comment:
not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
