codope commented on a change in pull request #3889:
URL: https://github.com/apache/hudi/pull/3889#discussion_r755819973
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileConfig.java
##########
@@ -34,19 +40,23 @@
private boolean dropBehindCacheCompaction;
private Configuration hadoopConf;
private BloomFilter bloomFilter;
-
- // This is private in CacheConfig so have been copied here.
- private static boolean DROP_BEHIND_CACHE_COMPACTION_DEFAULT = true;
+ private KeyValue.KVComparator hfileComparator;
public HoodieHFileConfig(Configuration hadoopConf, Compression.Algorithm
compressionAlgorithm, int blockSize,
long maxFileSize, BloomFilter bloomFilter) {
this(hadoopConf, compressionAlgorithm, blockSize, maxFileSize,
CacheConfig.DEFAULT_PREFETCH_ON_OPEN,
- HColumnDescriptor.DEFAULT_CACHE_DATA_IN_L1,
DROP_BEHIND_CACHE_COMPACTION_DEFAULT, bloomFilter);
+ HColumnDescriptor.DEFAULT_CACHE_DATA_IN_L1,
DROP_BEHIND_CACHE_COMPACTION_DEFAULT, bloomFilter, defaultHFileComparator);
+ }
+
+ public HoodieHFileConfig(Configuration hadoopConf, Compression.Algorithm
compressionAlgorithm, int blockSize,
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
