prashantwason commented on a change in pull request #4035:
URL: https://github.com/apache/hudi/pull/4035#discussion_r755668724
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -244,16 +246,24 @@ void emitCommitMetrics(String instantTime,
HoodieCommitMetadata metadata, String
}
/**
- * Any pre-commit actions like conflict resolution or updating metadata
table goes here.
+ * Any pre-commit actions like conflict resolution goes here.
* @param inflightInstant instant of inflight operation.
* @param metadata commit metadata for which pre commit is being invoked.
*/
protected void preCommit(HoodieInstant inflightInstant, HoodieCommitMetadata
metadata) {
- // Create a Hoodie table after starting the transaction which encapsulated
the commits and files visible.
- // Important to create this after the lock to ensure latest commits show
up in the timeline without need for reload
- HoodieTable table = createTable(config, hadoopConf);
- table.getMetadataWriter().ifPresent(w ->
((HoodieTableMetadataWriter)w).update(metadata, inflightInstant.getTimestamp(),
- table.isTableServiceAction(inflightInstant.getAction())));
+ // To be overridden by specific engines to perform conflict resolution if
any.
+ }
+
+ /**
+ * Write the HoodieCommitMetadata metadata table if available.
Review comment:
Write the HoodieCommitMetadata **to** metadata ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
