yihua commented on a change in pull request #3857:
URL: https://github.com/apache/hudi/pull/3857#discussion_r754834527
##########
File path:
hudi-kafka-connect/src/main/java/org/apache/hudi/connect/writers/KafkaConnectTransactionServices.java
##########
@@ -54,15 +55,20 @@
private final Option<HoodieTableMetaClient> tableMetaClient;
private final Configuration hadoopConf;
+ private final HoodieWriteConfig writeConfig;
+ private final KafkaConnectConfigs connectConfigs;
private final String tableBasePath;
private final String tableName;
private final HoodieEngineContext context;
private final HoodieJavaWriteClient<HoodieAvroPayload> javaClient;
public KafkaConnectTransactionServices(KafkaConnectConfigs connectConfigs)
throws HoodieException {
- HoodieWriteConfig writeConfig = HoodieWriteConfig.newBuilder()
- .withProperties(connectConfigs.getProps()).build();
+ this.connectConfigs = connectConfigs;
+ this.writeConfig = HoodieWriteConfig.newBuilder()
+ .withEngineType(EngineType.JAVA)
+ .withProperties(connectConfigs.getProps())
Review comment:
I'll let inline compaction and clustering be off by default without
enforcement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
