manojpec commented on a change in pull request #3968:
URL: https://github.com/apache/hudi/pull/3968#discussion_r752938891
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/SimpleKeyGenerator.java
##########
@@ -36,8 +37,9 @@
private final SimpleAvroKeyGenerator simpleAvroKeyGenerator;
public SimpleKeyGenerator(TypedProperties props) {
- this(props,
props.getString(KeyGeneratorOptions.RECORDKEY_FIELD_NAME.key()),
- props.getString(KeyGeneratorOptions.PARTITIONPATH_FIELD_NAME.key()));
+ this(props,
Review comment:
Right, changing the behavior of the default key gen is not desirable.
Now that we are setting the metadata table properties like record key, we
should always be reading the record with the right key for the metadata table.
Also, introduced a custom key gen for the metadata table which doesn't
dereference the partition filed from the record. Reverted all the changes
pertaining to key gen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
