yihua commented on a change in pull request #3746:
URL: https://github.com/apache/hudi/pull/3746#discussion_r735750112
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/util/TestParquetReaderIterator.java
##########
@@ -59,6 +61,7 @@ public void testParquetIterator() throws IOException {
assertEquals(1, iterator.next());
// no more entries to iterate on
assertFalse(iterator.hasNext());
- assertThrows(HoodieIOException.class, iterator::next, "should throw an
exception since there is only 1 record");
+ assertThrows(HoodieException.class, iterator::next, "should throw an
exception since there is only 1 record");
+ verify(reader, times(1)).close();
Review comment:
Yes, this looks good.
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/util/TestParquetReaderIterator.java
##########
@@ -59,6 +59,6 @@ public void testParquetIterator() throws IOException {
assertEquals(1, iterator.next());
// no more entries to iterate on
assertFalse(iterator.hasNext());
- assertThrows(HoodieIOException.class, iterator::next, "should throw an
exception since there is only 1 record");
+ assertThrows(HoodieException.class, iterator::next, "should throw an
exception since there is only 1 record");
Review comment:
@nsivabalan do you think changing `HoodieIOException` to
`HoodieException` is okay? My thought is that anything related I/O operations
should stay with `HoodieIOException`. Not sure if there's any convention in
the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
