xiarixiaoyao commented on a change in pull request #3203:
URL: https://github.com/apache/hudi/pull/3203#discussion_r725419860
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java
##########
@@ -445,10 +457,21 @@ public static HoodieMetadataConfig
buildMetadataConfig(Configuration conf) {
HoodieTableFileSystemView fsView =
fsViewCache.computeIfAbsent(metaClient, tableMetaClient ->
FileSystemViewManager.createInMemoryFileSystemViewWithTimeline(engineContext,
tableMetaClient, buildMetadataConfig(job), timeline));
List<HoodieBaseFile> filteredBaseFiles = new ArrayList<>();
+ Map<HoodieLogFile, List<String>> filteredLogs = new HashMap<>();
for (Path p : entry.getValue()) {
Review comment:
we need map here（Map<FileStatus, List<String>> filteredLogs)， since when
we build ReatimeFilesStatus we need the fileStatus of current log. of course
we can use List<List<String>>, but there is no need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
