YannByron commented on a change in pull request #3693:
URL: https://github.com/apache/hudi/pull/3693#discussion_r714881110
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/PartitionPathEncodeUtils.java
##########
@@ -71,7 +73,7 @@ public static String escapePathName(String path, String
defaultPath) {
if (defaultPath == null) {
//previously, when path is empty or null and no default path is
specified,
// __HIVE_DEFAULT_PARTITION__ was the return value for escapePathName
- return "__HIVE_DEFAULT_PARTITION__";
+ return HUDI_DEFAULT_PARTITION_PATH;
Review comment:
When the partition's value is null, hudi use "default" as the part of
path, rather than "__HIVE_DEFAULT_PARTITION__".
And I review the implement when need to encode partition path before #2645,
like `getRecordPartitionPath` and `getPartitionPath` in KeyGenUtils. I think
this just encode path, and use "default" when partitionPath is null or empty.
So i guess maybe this is forgotten to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
