vinothchandar commented on a change in pull request #3043:
URL: https://github.com/apache/hudi/pull/3043#discussion_r646986102
##########
File path:
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java
##########
@@ -245,7 +246,6 @@ public void testBasicSync(boolean useJdbc, boolean
useSchemaFromCommitMetadata)
hiveClient = new HoodieHiveClient(HiveTestUtil.hiveSyncConfig,
HiveTestUtil.getHiveConf(), HiveTestUtil.fileSystem);
List<Partition> hivePartitions =
hiveClient.scanTablePartitions(HiveTestUtil.hiveSyncConfig.tableName);
List<String> writtenPartitionsSince =
hiveClient.getPartitionsWrittenToSince(Option.empty());
- writtenPartitionsSince.add(newPartition.get(0));
Review comment:
cc @n3nash to chime in
##########
File path:
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/testutils/HiveTestUtil.java
##########
@@ -110,12 +105,12 @@ public static void setUp() throws IOException,
InterruptedException {
fileSystem = FileSystem.get(configuration);
hiveSyncConfig = new HiveSyncConfig();
- hiveSyncConfig.jdbcUrl = "jdbc:hive2://127.0.0.1:9999/";
+ hiveSyncConfig.jdbcUrl = hiveTestService.getJdbcHive2Url();
Review comment:
yes. removing this hardcoding is awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
