danny0405 commented on code in PR #20165:
URL: https://github.com/apache/hudi/pull/20165#discussion_r4278548208
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java:
##########
@@ -110,6 +112,9 @@ public class HiveSyncTool extends HoodieSyncTool implements
AutoCloseable {
private String hiveSyncTableStrategy;
+ // never null, so getSyncStats() also works when no sync ran, e.g. when the
metastore client could not be created
+ private HiveSyncStats syncStats = new HiveSyncStats();
Review Comment:
can we add an option to guard the detailed stats collection and by default
disable it so that other engines/use cases are not affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
