hudi-agent commented on code in PR #20121:
URL: https://github.com/apache/hudi/pull/20121#discussion_r4235340089
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -270,7 +270,16 @@ class HoodieSparkSqlWriterInternal {
(false, common.util.Option.empty(), common.util.Option.empty(),
common.util.Option.empty(), hoodieWriteClient.orNull, tableConfig)
} else {
// Handle various save modes
- handleSaveModes(sparkSession, mode, basePath, tableConfig, tblName,
operation, fs)
+ val saveModeOperation =
Review Comment:
🤖 nit: could you pull this three-part condition into a named val like
`isRowWriterInsertOverwriteTable`, with a short comment explaining why
save-mode handling needs the original overwrite type? Right now the intent is
hard to see inside the `if`.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
