voonhous commented on code in PR #19674:
URL: https://github.com/apache/hudi/pull/19674#discussion_r4230554397
##########
packaging/bundle-validation/validate.sh:
##########
@@ -69,6 +76,91 @@ use_default_java_runtime () {
export JAVA_HOME=${DEFAULT_JAVA_HOME}
}
+##
+# Function to test the spark native bundle, which carries Apache DataFusion
Comet.
+#
+# Comet ships class file version 61 bytecode and a glibc linked libcomet.so,
so this only runs on
Review Comment:
**blocker:** Where this check does run, it runs on a musl JVM, so it fails
on release day. The Java 17 pass uses the base image's Alpine `apk` openjdk17
(`base/Dockerfile:17-19`), while `libcomet.so` needs glibc.
`release_candidate_validation.yml` reaches this step for 3.5_2.13, 3.4, 4.0 and
4.1; round 2 already hit `UnsatisfiedLinkError: __fprintf_chk` on this image
([job](https://github.com/apache/hudi/actions/runs/32530451230/job/96921282907)).
Could we skip with a warning when `/lib/ld-musl-x86_64.so.1` exists until a
glibc base image is published, and fix the `bundle-validation/README.md` line
implying the Java 17 pass avoids musl?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
