hudi-agent commented on code in PR #20133:
URL: https://github.com/apache/hudi/pull/20133#discussion_r4129550698
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieNativeLogAppendHandle.java:
##########
@@ -162,8 +163,8 @@ protected void flushAppend() {
writer.flushAppend(getUpdatedHeader(header));
processAppendResults(writer.getLastAppendResults());
}
- } catch (IOException e) {
- throw new HoodieAppendException("Failed while flushing records to native
log for fileId " + fileId, e);
+ } catch (Throwable e) {
Review Comment:
🤖 Catching `Throwable` here also wraps JVM-fatal errors like
`OutOfMemoryError` or `StackOverflowError` in a `RuntimeException`. The engines
then see an ordinary task failure instead of a fatal error. Would `catch
(Exception e)` be enough, or could `VirtualMachineError` be rethrown unwrapped?
`writeRecord`/`doAppend` would still close the writer through their own
handling.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
