danny0405 commented on code in PR #20072:
URL: https://github.com/apache/hudi/pull/20072#discussion_r4118504784


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/index/GlobalRecordLevelIndexBackend.java:
##########
@@ -169,7 +169,6 @@ public void onCheckpointComplete(Correspondent 
correspondent, long completedChec
     // the latest completed checkpoint id is used as the minimum checkpoint id,
     // since the streaming write operator always uses previous checkpoint id 
to request the new instant.
     
recordIndexCache.markAsEvictable(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointID));
-    this.metaClient.reloadActiveTimeline();

Review Comment:
   +1



##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/index/RecordLevelIndexBackend.java:
##########
@@ -154,7 +154,6 @@ public void onCheckpoint(long checkpointId) {
   public void onCheckpointComplete(Correspondent correspondent, long 
completedCheckpointId) {
     Map<Long, String> inflightInstants = 
correspondent.requestInflightInstants();
     
updateEvictableCkp(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointId));
-    metaClient.reloadActiveTimeline();

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to