voonhous opened a new pull request, #20052: URL: https://github.com/apache/hudi/pull/20052
### Describe the issue this Pull Request addresses `FileCreateUtils` and `FileCreateUtilsLegacy` both extend `FileCreateUtilsBase`, but each carries its own copy of static helpers that are the same in both: - `markerFileName(String, IOType)` and `isBaseOrLogFilename(String)` are already defined on `FileCreateUtilsBase`. The subclasses redeclare them with identical bodies (`FileCreateUtilsLegacy` only shadows `isBaseOrLogFilename`). - `getPartitionPaths`, `getBaseFilePath`, `renameFileToTemp` and `renameTempToMetaFile` are byte-identical in both subclasses and not on the base. ### Summary and Changelog - Delete the shadowing `markerFileName` / `isBaseOrLogFilename` copies from the subclasses. - Move `getPartitionPaths`, `getBaseFilePath`, `renameFileToTemp` and `renameTempToMetaFile` to `FileCreateUtilsBase`, and delete them from both subclasses. - Drop the imports that became unused. No caller changes. The callers in `HoodieTestTable`, `TestHoodieBackedMetadata`, `TestJavaHoodieBackedMetadata`, `TestHoodieMetadataBootstrap` and `ITTestBucketStreamWrite` use `FileCreateUtils.x(...)` / `FileCreateUtilsLegacy.x(...)`, which resolve to the inherited static. ### Impact Test code only. No behavior change. ### Risk Level none ### Documentation Update none ### Contributor's checklist - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [x] Enough context is provided in the sections above - [ ] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
