hudi-agent commented on code in PR #19948:
URL: https://github.com/apache/hudi/pull/19948#discussion_r4069990012
##########
hudi-common/src/main/java/org/apache/hudi/core/read/BaseHoodieTableFileIndex.java:
##########
@@ -402,7 +403,10 @@ protected List<PartitionPath>
listPartitionPaths(List<String> relativePartitionP
List<String> matchedPartitionPaths;
try {
if (isPartitionedTable()) {
- if (queryType == HoodieTableQueryType.INCREMENTAL &&
incrementalQueryStartTime.isPresent() && !isBeforeTimelineStarts()) {
+ if (queryType == HoodieTableQueryType.INCREMENTAL
Review Comment:
🤖 nit: this predicate now has four clauses; it might be worth pulling it
into a small helper like `canListPartitionsFromIncrementalTimeline()` so the
intent ("we have a concrete start instant that is still on the active
timeline") reads at a glance.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
