yihua commented on code in PR #19304:
URL: https://github.com/apache/hudi/pull/19304#discussion_r4065324209
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java:
##########
@@ -419,9 +446,7 @@ public static boolean
isAutoGeneratedRecordKeysEnabled(TypedProperties props) {
}
public static boolean
isComplexKeyGeneratorWithSingleRecordKeyField(HoodieTableConfig tableConfig) {
- Option<String[]> recordKeyFields = tableConfig.getRecordKeyFields();
- return KeyGeneratorType.isComplexKeyGenerator(tableConfig)
- && recordKeyFields.isPresent() && recordKeyFields.get().length == 1;
+ return tableConfig.isComplexKeyGenWithSingleRecordKeyField();
}
Review Comment:
nit: remove this wrapper, and make caller to directly use
`tableConfig.isComplexKeyGenWithSingleRecordKeyField()` to simplify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
