voonhous commented on code in PR #19986:
URL: https://github.com/apache/hudi/pull/19986#discussion_r4056844010


##########
.github/workflows/bot.yml:
##########
@@ -1509,43 +1509,60 @@ jobs:
           SCALA_PROFILE: '-Dscala-2.12 -Dscala.binary.version=2.12'
         run:
           mvn test $SCALA_PROFILE -D"$SPARK_PROFILE" -Pintegration-tests 
-DskipUTs=false -DskipITs=true -pl hudi-integ-test $MVN_ARGS -Djacoco.skip=false
+      - name: Restore Spark archive

Review Comment:
   **minor:** Not blocking, but the "up to 68 minutes" in Impact is a 
pre-#19884 number. Measured on six master runs since dlcdn landed, the download 
takes 1-18s (median ~11s) against a ~36 minute job, and a 382MB restore is 
~4.5s extrapolated from a 1435MB restore in ~17s (job 105516288805). Net is 
roughly 6-14s.
   
   Could we restate Impact as removing a 382MB egress and its stale-pin tail 
risk, rather than as minutes?
   
   The degradation may happen as Spark does more releases and drop the pinned 
version such that it is no longer in fastkly's CDN and CI has to resolve via 
archive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to