voonhous opened a new issue, #20004:
URL: https://github.com/apache/hudi/issues/20004

   Follow-up to #18780 (RFC-105 hudi-trino migration), raised in review of 
trinodb/trino#30682.
   
   ### What
   
   `hudi-trino` ships `io.trino.plugin.hudi.HudiPlugin` (checked in 
`hudi-trino-1.2.1-rc2.jar`), but no `META-INF/services/io.trino.spi.Plugin` 
descriptor, so Trino never loads it. The entry point Trino actually uses is the 
`HudiPlugin` in Trino's `plugin/trino-hudi` module, which wraps 
`HudiConnectorFactory` from `hudi-trino`.
   
   Because both jars contain the same class, Trino's `trino-hudi` pom has to 
tell `duplicate-finder` to ignore `io.trino.plugin.hudi.HudiPlugin`.
   
   ### Proposed fix
   
   Remove `HudiPlugin` from `hudi-trino`'s main sources. If Hudi-side tests 
need a plugin to install the connector, keep a test-only equivalent (for 
example `TestingHudiPlugin`).
   
   ### Why here
   
   Under RFC-105 the Trino-side `HudiPlugin` is the only entry point, and the 
class in `hudi-trino` can only be removed here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to