linliu-code commented on PR #782: URL: https://github.com/apache/hudi-rs/pull/782#issuecomment-5701458018
## Do not review yet — this does not compile Flagging a defect I introduced, before anyone spends time on it. This branch replaces `cpp/src/lib.rs` with the ported bridge, which exports `new_file_group_reader_with_context`. It does **not** carry a matching change to the demo, which still calls the previous name: ``` demo/apps/hudi-file-group-api/cpp/main.cpp:142:34: error: 'new_file_group_reader_with_options' was not declared in this scope; did you mean 'new_file_group_reader_with_context'? ``` `main` is self-consistent today — it exports `new_file_group_reader_with_options` and the demo calls it. The port renames the entry point and leaves the caller behind, so `integration-tests (hudi-file-group-api/cpp)` fails to build. **Scope:** this affects this PR and the one stacked after it. The two earlier positions in the series (#780, #781) do not touch `cpp/src/lib.rs` and are unaffected. **How it got here:** the branch was assembled by cherry-pick and pushed without a local build — the crate does not currently build in my environment, and CI had not run here yet, so nothing caught it. That is on me, not on the original author. **What happens next:** the same failure exists on the internal PR this was ported from, and is being fixed there. I will re-port once that lands rather than invent a rename here that diverges from the internal series. Staying in draft until then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
