rangareddy commented on code in PR #19815:
URL: https://github.com/apache/hudi/pull/19815#discussion_r3923201959
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########
@@ -240,7 +240,9 @@ public class HoodieStorageConfig extends HoodieConfig {
.key("hoodie.parquet.outputtimestamptype")
.defaultValue("TIMESTAMP_MICROS")
.markAdvanced()
- .withDocumentation("Sets spark.sql.parquet.outputTimestampType. Parquet
timestamp type to use when Spark writes data to Parquet files.");
+ .withDocumentation("Sets spark.sql.parquet.outputTimestampType for the
Spark row-writer Parquet path (for example bulk insert). "
Review Comment:
Correction to my earlier reply on this thread: I dropped the dead
`hadoopConf.set` as you asked, but I have kept
`HoodieWriteConfig.parquetOutputTimestampType()` and marked it `@Deprecated`
rather than deleting it. It has no callers in the tree, but it is public, and
`HoodieWriteConfig` deprecates public members rather than removing them (76
`@Deprecated` markers in that class), so deleting it would be
source-incompatible for downstream integrations with no benefit. The javadoc
says the returned value does not describe what gets written, which I think
serves the same purpose you were after. Happy to delete it instead if you would
rather.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
