cshuo commented on code in PR #19399:
URL: https://github.com/apache/hudi/pull/19399#discussion_r3671654359
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/utils/InsertFunctionWrapper.java:
##########
@@ -209,9 +211,22 @@ public AbstractWriteFunction getWriteFunction() {
@Override
public void close() throws Exception {
- this.coordinator.close();
- if (clusteringFunctionWrapper != null) {
- clusteringFunctionWrapper.close();
+ try {
+ if (writeFunction != null) {
+ writeFunction.close();
+ }
+ } finally {
+ try {
+ this.coordinator.close();
+ } finally {
+ try {
+ this.ioManager.close();
+ } finally {
+ if (clusteringFunctionWrapper != null) {
+ clusteringFunctionWrapper.close();
Review Comment:
Fixed in 284fb5ff351. The clustering plan operator, clustering operator, and
commit sink now close before either IO manager, with null guards and ordered
cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
