vinothchandar commented on code in PR #19265:
URL: https://github.com/apache/hudi/pull/19265#discussion_r3634275791
##########
hudi-lakehouse/charts/hudi-trino/templates/_helpers.tpl:
##########
@@ -0,0 +1,52 @@
+{{- /*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
Review Comment:
w.r.t Trino, I think we need
- the work you are doing to make the shims and change upstream trino to
depend on them for the Hudi connector. So new code in connector sits mostly in
this repo
- then we make trino production ready deployable in this chart you see in
this PR. i.e improve this chart and make everything production ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
