wombatu-kun commented on code in PR #19204: URL: https://github.com/apache/hudi/pull/19204#discussion_r3555982616
########## hudi-common/src/test/java/org/apache/hudi/common/bloom/TestSimpleBloomFilter.java: ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.bloom; + +import org.apache.hudi.common.util.hash.Hash; + +import org.junit.jupiter.api.Test; + +import java.nio.ByteBuffer; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * Tests {@link SimpleBloomFilter}. + */ +public class TestSimpleBloomFilter { + + @Test + public void testAddAndMightContain() { Review Comment: The overlap is real, but `TestBloomFilter` lives in `hudi-hadoop-common`, not in this module, and nothing under `hudi-common/src/test` references `SimpleBloomFilter` today. Dropping all three would leave the class with no coverage at all from `hudi-common`'s own suite, which is what this PR is measuring. Keeping one add/mightContain smoke case alongside the genuinely-new ones, and dropping only `testOrMergesTwoFilters` and `testSerializeToStringRoundTrip`, gets the dedup without the regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
