nada-attia commented on code in PR #18941:
URL: https://github.com/apache/hudi/pull/18941#discussion_r3554178698
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestHoodieBackedMetadata.java:
##########
@@ -1944,6 +1945,88 @@ public void testClusteringWithRecordIndex() throws
Exception {
testTableOperationsForMetaIndexImpl(writeConfig);
}
+ /**
+ * Record index bootstrap over binary / non-ASCII record keys must succeed.
The RI HFile orders
+ * keys by their raw UTF-8 bytes, so the bulk-insert partitioner must sort
by UTF-8 bytes too;
+ * sorting by {@link String#compareTo(String)} (UTF-16) fails with
+ * "Added a key not lexically larger than previous".
+ */
+ @Test
+ public void testRecordIndexBootstrapWithBinaryRecordKeys() throws Exception {
Review Comment:
added the two tests mentioned and added some tests in TestStringUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
