yihua commented on PR #19163: URL: https://github.com/apache/hudi/pull/19163#issuecomment-4906097561
Note on the one remaining red check (`test-spark-java17-scala-dml-tests`, scala-2.13 / spark3.5): it fails on `Test Query Log Only MOR Table`, a pre-existing test that this PR does not touch. Evidence it is a pre-existing MOR inline-compaction timing flake surfaced by (not caused by) the added suite load: * The tests added in this PR all pass. * `Test Query Log Only MOR Table` passes locally when run in one JVM alongside the tests added here. * It passes on the sibling coverage PRs (#19161, #19165) that run the same `scala-dml` wildcard suite; it only fails here, on the 2.13/spark3.5 cell. Code review comments have been addressed. The alter-table coverage was scoped to the add / type-widen / comment paths, since rename and drop are already covered end to end by `TestSpark3DDL`. Happy to re-run the job or trim the bulk-insert case if reviewers prefer a fully green run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
