nsivabalan commented on code in PR #18611:
URL: https://github.com/apache/hudi/pull/18611#discussion_r3531975580
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1114,6 +1117,8 @@ private List<DirectoryInfo>
listAllPartitionsFromFilesystem(String initializatio
}
}
+ final long zeroSizeCount = totalZeroSizeFiles;
+ metrics.ifPresent(m -> m.incrementMetric("bootstrap_zero_size_files",
zeroSizeCount));
Review Comment:
`bootstrap_zero_size_files` - > `skipped_zero_size_files_on_initialize`
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -195,6 +195,14 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
.sinceVersion("0.7.0")
.withDocumentation("Directories matching this regex, will be filtered
out when initializing metadata table from lake storage for the first time.");
+ public static final ConfigProperty<Boolean>
SKIP_ZERO_SIZE_FILES_DURING_BOOTSTRAP = ConfigProperty
Review Comment:
we already have a feature named "bootstrap" which is used for something
else. so lets avoid using that.
```
METADATA_PREFIX + ".skip.zero.size.files.on.initialize"
```
Also, lets fix the getter apis accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
