cshuo commented on code in PR #19198:
URL: https://github.com/apache/hudi/pull/19198#discussion_r3528967044
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieLogFile.java:
##########
@@ -181,7 +173,9 @@ public String getFileExtension() {
}
public boolean isCDC() {
- return FSUtils.isCDCLogFile(getFileName());
+ return isNativeLogFile()
Review Comment:
This inlines the same ternary as
`FileNameParser.LogFileName#isCDCLogFile()`, so CDC detection now lives in two
places that must stay in sync. Since `parseFieldsFromPath()` already has the
parsed `LogFileName`, could we cache the boolean there (or delegate to a shared
static predicate)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
