hudi-agent commented on code in PR #19163: URL: https://github.com/apache/hudi/pull/19163#discussion_r3523681127
########## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/insert/TestBulkInsertRowWriterCommitCoverage.scala: ########## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.sql.hudi.dml.insert + +import org.apache.hudi.HoodieCLIUtils +import org.apache.hudi.common.util.{Option => HOption} + +import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase + +/** + * Focused coverage for the row-writer bulk-insert commit executors in + * {@code org.apache.hudi.commit}: [[org.apache.hudi.commit.BaseDatasetBulkInsertCommitActionExecutor]] Review Comment: 🤖 nit: `{@code org.apache.hudi.commit}` (Javadoc syntax) is mixed with `[[...]]` Scaladoc links in the same sentence — could you use backticks or `[[org.apache.hudi.commit]]` for the package reference to stay consistent with the rest of the doc comment? <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> ########## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/ddl/TestAlterTableColumnCoverage.scala: ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.hudi.ddl + +import org.apache.hudi.HoodieSparkUtils + +import org.apache.spark.sql.catalyst.TableIdentifier +import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase + +/** + * Column add / rename / drop / position / comment coverage for + * [[org.apache.spark.sql.hudi.command.AlterTableCommand]] driven through the schema-on-read + * (schema evolution) path. Uses an unpartitioned table so the {@code commitWithSchema} data-schema + * derivation takes the no-partition-column branch, complementing the partitioned coverage in + * {@code TestSpark3DDL}. + */ +class TestAlterTableColumnCoverage extends HoodieSparkSqlTestBase { Review Comment: 🤖 nit: `{@code TestSpark3DDL}` won't produce a navigable cross-reference in Scaladoc — `[[TestSpark3DDL]]` would make it clickable and keep the style consistent with the `[[AlterTableCommand]]` link on the line above. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
