voonhous commented on code in PR #19155:
URL: https://github.com/apache/hudi/pull/19155#discussion_r3519786894
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##########
@@ -463,7 +463,7 @@ private boolean deleteArchivedInstants(List<HoodieInstant>
archivedInstants, Hoo
public void archive(HoodieEngineContext context, List<HoodieInstant>
instants) throws HoodieCommitException {
try {
Schema wrapperSchema = HoodieArchivedMetaEntry.getClassSchema();
- log.info("Wrapper schema " + wrapperSchema.toString());
+ log.info("Wrapper schema {}", wrapperSchema.toString());
Review Comment:
Done. Dropped `.toString()` in `TimelineArchiverV1` and
`HoodieCompactionPlanGenerator` (plus the matching test in
`TestLegacyArchivedMetaEntryReader`). `LSMTimelineWriter` already passes the
schema object straight through after the rebase, so nothing needed there.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/plan/generators/HoodieCompactionPlanGenerator.java:
##########
@@ -47,7 +47,7 @@ public HoodieCompactionPlanGenerator(HoodieTable table,
HoodieEngineContext engi
BaseTableServicePlanActionExecutor
executor) {
super(table, engineContext, writeConfig, executor);
this.compactionStrategy = writeConfig.getCompactionStrategy();
- log.info("Compaction Strategy used is: " + compactionStrategy.toString());
+ log.info("Compaction Strategy used is: {}", compactionStrategy.toString());
Review Comment:
Done here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
