hudi-agent commented on code in PR #19081:
URL: https://github.com/apache/hudi/pull/19081#discussion_r3501256735
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieTTLConfig.java:
##########
@@ -112,6 +138,21 @@ public HoodieTTLConfig.Builder
withTTLStrategyType(PartitionTTLStrategyType ttlS
return this;
}
+ public HoodieTTLConfig.Builder withEventTimeFormat(String format) {
+ ttlConfig.setValue(EVENT_TIME_FORMAT, format);
+ return this;
+ }
+
+ public HoodieTTLConfig.Builder withEventTimePartitionStartIndex(int
startIndex) {
+ ttlConfig.setValue(EVENT_TIME_PARTITION_START_INDEX,
Integer.toString(startIndex));
+ return this;
+ }
+
+ public HoodieTTLConfig.Builder withDeleteHiveDefaultPartition(boolean
enable) {
Review Comment:
🤖 nit: the sibling builders are `withEventTimeFormat` /
`withEventTimePartitionStartIndex`, but this one drops the `EventTime` prefix.
Could you rename it to `withEventTimeDeleteHiveDefaultPartition` so it's clear
this knob belongs to the event-time TTL group (and matches the
`EVENT_TIME_DELETE_HIVE_DEFAULT_PARTITION` config)?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
