cshuo commented on code in PR #19079:
URL: https://github.com/apache/hudi/pull/19079#discussion_r3490225308
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieNativeLogAppendHandle.java:
##########
@@ -101,6 +101,7 @@ protected void createLogWriterForAppend(String instantTime,
Option<FileSlice> fi
getLogCreationCallback(),
config.getWriteVersion(),
config,
+ hoodieTable.getBaseFileFormat(),
Review Comment:
Agreed. But currently there's nothing enforcing `LOG_FILE_FORMAT ==
BASE_FILE_FORMAT` for LSM — write side uses `getBaseFileFormat()` while the
reader validates `getLogFileFormat()` (`HoodieLsmFileGroupReader#L111`), so
they can drift. Could the reader just validates the base file format directly,
or writer validates `LOG_FILE_FORMAT == BASE_FILE_FORMAT` when creating the LSM
table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
