hudi-agent commented on code in PR #17825:
URL: https://github.com/apache/hudi/pull/17825#discussion_r3348115610
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -77,28 +81,53 @@
* and {@code RowData} in Flink.
*/
public abstract class HoodieReaderContext<T> {
+
+ @Getter
private final StorageConfiguration<?> storageConfiguration;
protected final HoodieFileFormat baseFileFormat;
// For general predicate pushdown.
+ @Getter
protected final Option<Predicate> keyFilterOpt;
protected final HoodieTableConfig tableConfig;
+ @Setter
private String tablePath = null;
+ @Getter
+ @Setter
private String latestCommitTime = null;
+ @Getter
+ @Setter
private Option<HoodieRecordMerger> recordMerger = null;
+ @Getter
+ @Setter
private Boolean hasLogFiles = null;
+ @Getter
+ @Setter
private Boolean hasBootstrapBaseFile = null;
+ @Getter
+ @Setter
private Boolean needsBootstrapMerge = null;
+ @Getter
+ @Setter
// should we do position based merging for mor
private Boolean shouldMergeUseRecordPosition = null;
protected Option<InstantRange> instantRangeOpt;
+ @Getter
private RecordMergeMode mergeMode;
+ @Getter
protected RecordContext<T> recordContext;
+ @Getter
+ @Setter
private FileGroupReaderSchemaHandler<T> schemaHandler = null;
// the default iterator mode is engine-specific record mode
+ @Setter
private IteratorMode iteratorMode = IteratorMode.ENGINE_RECORD;
+ @Getter
protected final HoodieConfig hoodieReaderConfig;
- private boolean enableLogicalTimestampFieldRepair = true;
+ @Getter
+ @Setter
+ @Accessors(fluent = true)
+ private Boolean enableLogicalTimestampFieldRepair = true;
Review Comment:
🤖 nit: was there a reason to change this from primitive `boolean` to boxed
`Boolean`? It's defaulted to `true` and never appears to need a null state, so
keeping it `boolean` would avoid unnecessary autoboxing on the Scala caller
side and make the type as expressive as the original.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-common/src/main/java/org/apache/hudi/common/data/HoodieBaseListData.java:
##########
@@ -34,6 +35,7 @@
*
* @param <T> Object value type.
*/
+@Slf4j
public abstract class HoodieBaseListData<T> {
Review Comment:
🤖 nit: the outer class doesn't appear to use `log` anywhere — only the inner
`IteratorCloser` does (which has its own `@Slf4j`). Could you drop `@Slf4j`
from the outer class to avoid generating an unused logger?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
