nbalajee commented on code in PR #18279: URL: https://github.com/apache/hudi/pull/18279#discussion_r3047101168
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackHelperV1.java: ########## Review Comment: Agree that a comment is warranted here. Will add a brief comment at L239 noting that getCurrentSize() is called after appendBlock() which internally calls hsync(), so the stream position reflects the true on-disk size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
