mailtoboggavarapu-coder opened a new pull request, #18470: URL: https://github.com/apache/hudi/pull/18470
### Describe the issue this Pull Request addresses ### Describe the issue this Pull Request addresses **Problem** `FileIOUtils.readAsUTFStringLines` creates a `BufferedReader` but relies on a manual `closeQuietly` call placed after `bufferedReader.lines().collect()`. If `collect()` throws an exception, the `closeQuietly` line is never reached, leaving the `BufferedReader` open — a resource leak. **Fix** Replace the manual resource management with try-with-resources, which guarantees the `BufferedReader` is closed on both normal and exceptional exit paths. ### Brief change log * Replace manual `closeQuietly` call with try-with-resources in `FileIOUtils.readAsUTFStringLines` * Add `IOException` catch block that wraps and rethrows as `RuntimeException` ### Verify this pull request does not require a change to the documentation in https://hudi.apache.org/docs/ No documentation changes required. ### Verify this pull request does not introduce any regression or new bugs This is a pure resource management fix. The method behaviour is unchanged under normal execution paths — it still reads the input stream and returns a list of UTF-8 decoded strings. The try-with-resources pattern only ensures the `BufferedReader` is always closed. <!-- Either describe the issue inline here with motivation behind the changes (or) link to an issue by including `Closes #<issue-number>` for context. If this PR includes changes to the storage format, public APIs, or has breaking changes, use `!` (e.g., feat!: ...) --> ### Summary and Changelog <!-- Short, plain-English summary of what users gain or what changed in behavior. Followed by a detailed log of all the changes. Highlight if any code was copied. --> ### Impact <!-- Describe any public API or user-facing feature change or any performance impact. --> ### Risk Level <!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk. If medium or high, explain what verification was done to mitigate the risks. --> ### Documentation Update <!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none". - The config description must be updated if new configs are added or the default value of the configs are changed. - Any new feature or user-facing change requires updating the Hudi website. Please follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. --> ### Contributor's checklist - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [ ] Enough context is provided in the sections above - [ ] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
