linliu-code commented on code in PR #18224:
URL: https://github.com/apache/hudi/pull/18224#discussion_r3034639568
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/KinesisSourceConfig.java:
##########
@@ -38,116 +37,113 @@
description = "Configurations controlling the behavior of Kinesis source
in Hudi Streamer.")
public class KinesisSourceConfig extends HoodieConfig {
- public static final String KINESIS_CHECKPOINT_TYPE_STRING = "string";
-
private static final String PREFIX = STREAMER_CONFIG_PREFIX +
"source.kinesis.";
- private static final String OLD_PREFIX = DELTA_STREAMER_CONFIG_PREFIX +
"source.kinesis.";
public static final ConfigProperty<String> KINESIS_STREAM_NAME =
ConfigProperty
.key(PREFIX + "stream.name")
.noDefaultValue()
- .withAlternatives(OLD_PREFIX + "stream.name")
.withDocumentation("Kinesis Data Streams stream name.");
public static final ConfigProperty<String> KINESIS_REGION = ConfigProperty
.key(PREFIX + "region")
.noDefaultValue()
- .withAlternatives(OLD_PREFIX + "region")
+ .markAdvanced()
.withDocumentation("AWS region for the Kinesis stream (e.g.,
us-east-1).");
public static final ConfigProperty<String> KINESIS_ENDPOINT_URL =
ConfigProperty
.key(PREFIX + "endpoint.url")
.noDefaultValue()
- .withAlternatives(OLD_PREFIX + "endpoint.url")
.markAdvanced()
.withDocumentation("Custom endpoint URL for Kinesis (e.g., for
localstack). "
+ "If not set, uses the default AWS endpoint for the region.");
public static final ConfigProperty<String> KINESIS_ACCESS_KEY =
ConfigProperty
.key(PREFIX + "access.key")
.noDefaultValue()
- .withAlternatives(OLD_PREFIX + "access.key")
.markAdvanced()
.withDocumentation("AWS access key for Kinesis. Used when connecting to
custom endpoints (e.g., LocalStack). "
+ "If not set with endpoint, uses the default AWS credential
chain.");
public static final ConfigProperty<String> KINESIS_SECRET_KEY =
ConfigProperty
.key(PREFIX + "secret.key")
.noDefaultValue()
- .withAlternatives(OLD_PREFIX + "secret.key")
.markAdvanced()
.withDocumentation("AWS secret key for Kinesis. Used when connecting to
custom endpoints (e.g., LocalStack). "
+ "If not set with endpoint, uses the default AWS credential
chain.");
public static final ConfigProperty<Long> MAX_EVENTS_FROM_KINESIS_SOURCE =
ConfigProperty
- .key(STREAMER_CONFIG_PREFIX + "kinesis.source.maxEvents")
+ .key(PREFIX + "max.events")
.defaultValue(5000000L)
- .withAlternatives(DELTA_STREAMER_CONFIG_PREFIX +
"kinesis.source.maxEvents")
.markAdvanced()
.withDocumentation("Maximum number of records obtained in each batch
from Kinesis.");
- public static final ConfigProperty<Long> KINESIS_SOURCE_MIN_PARTITIONS =
ConfigProperty
- .key(PREFIX + "minPartitions")
+ public static final ConfigProperty<Long> KINESIS_SOURCE_MANUAL_PARTITIONS =
ConfigProperty
+ .key(PREFIX + "manual.partitions")
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
